Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: clippy unused #434

Merged
merged 10 commits into from
Jan 22, 2024
Merged

fix: clippy unused #434

merged 10 commits into from
Jan 22, 2024

Conversation

gruberb
Copy link
Contributor

@gruberb gruberb commented Jan 19, 2024

Description

Remove unused = "allow" from the Cargo.toml to highlight unused imports and variables. Cleaning up the warnings.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@gruberb gruberb requested a review from a team as a code owner January 19, 2024 18:35
@gruberb gruberb changed the title Fix/clippy unused fix: clippy unused Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43c6fe5) 68.96% compared to head (deaac0e) 68.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   68.96%   68.86%   -0.11%     
==========================================
  Files         220      220              
  Lines       12103    12099       -4     
==========================================
- Hits         8347     8332      -15     
- Misses       3756     3767      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the question about dead code.

@gruberb gruberb merged commit 4aa6a9e into main Jan 22, 2024
21 checks passed
@gruberb gruberb deleted the fix/clippy-unused branch January 22, 2024 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants