This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
- Coverage 68.96% 68.86% -0.11%
==========================================
Files 220 220
Lines 12103 12099 -4
==========================================
- Hits 8347 8332 -15
- Misses 3756 3767 +11 ☔ View full report in Codecov by Sentry. |
gruberb
force-pushed
the
fix/clippy-unused
branch
from
January 19, 2024 19:47
f3dcc83
to
e6ef786
Compare
gruberb
force-pushed
the
fix/clippy-unused
branch
from
January 19, 2024 19:54
e6ef786
to
98d77d5
Compare
Freyskeyd
reviewed
Jan 19, 2024
dvdplm
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the question about dead code.
Freyskeyd
approved these changes
Jan 20, 2024
atanmarko
approved these changes
Jan 22, 2024
gruberb
commented
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
unused = "allow"
from theCargo.toml
to highlight unused imports and variables. Cleaning up the warnings.PR Checklist: